vinothchandar commented on a change in pull request #600: Timeline Service
with Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276700416
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieFileGroup.java
##########
@@ -197,7 +205,20 @@ public String toString() {
final StringBuilder sb = new StringBuilder("HoodieFileGroup {");
sb.append("id=").append(fileGroupId);
sb.append(", fileSlices='").append(fileSlices).append('\'');
+ sb.append(", lastInstant='").append(lastInstant).append('\'');
sb.append('}');
return sb.toString();
}
+
+ public void addFileSlice(FileSlice slice) {
+ fileSlices.put(slice.getBaseInstantTime(), slice);
+ }
+
+ public Stream<FileSlice> getAllRawFileSlices() {
Review comment:
rename: getFileSlices()? why Raw?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services