bvaradar commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r276898518
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -51,14 +52,19 @@
public static final SimpleDateFormat COMMIT_FORMATTER = new
SimpleDateFormat("yyyyMMddHHmmss");
+ //TODO: Ask @nishith what does it take to treat rollback extensions. Is it
enough if we start archiving Rollback
+ // timeline
+ public static final Set<String> VALID_ROLLBACK_EXTENSIONS = new
HashSet<>(Arrays.asList(INFLIGHT_ROLLBACK_EXTENSION,
Review comment:
This was a temporary change I was trying. Ended up reverting as it is not
needed after your change to decouple rollback from restore. I have removed this
line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
