vinothchandar commented on a change in pull request #653: Fixes HUDI-85 :
Interval tree based pruning for Bloom Index
URL: https://github.com/apache/incubator-hudi/pull/653#discussion_r279486601
##########
File path:
hoodie-client/src/test/java/com/uber/hoodie/index/bloom/TestHoodieGlobalBloomIndex.java
##########
@@ -211,10 +211,10 @@ public void testExplodeRecordRDDWithFileComparisons() {
t -> t._2()._2().getRecordKey(), Collectors.mapping(t ->
t._2()._1().split("#")[0], Collectors.toList())));
assertEquals(4, recordKeyToFileComps.size());
- assertEquals(Arrays.asList("f4", "f1", "f3"),
recordKeyToFileComps.get("002"));
- assertEquals(Arrays.asList("f4", "f1", "f3"),
recordKeyToFileComps.get("003"));
- assertEquals(Arrays.asList("f4", "f1"), recordKeyToFileComps.get("004"));
- assertEquals(Arrays.asList("f4", "f1"), recordKeyToFileComps.get("005"));
+ assertEquals(new HashSet<>(Arrays.asList("f4", "f1", "f3")), new
HashSet<>(recordKeyToFileComps.get("002")));
Review comment:
that is purely a performance related artifact right? I ll look at improving
coverage holistically, down the line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
