ambition119 commented on a change in pull request #657: [HUDI-57] support orc file URL: https://github.com/apache/incubator-hudi/pull/657#discussion_r281006108
########## File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieStorageConfig.java ########## @@ -51,6 +51,19 @@ // Default compression ratio for log file to parquet, general 3x public static final String DEFAULT_LOGFILE_TO_PARQUET_COMPRESSION_RATIO = String.valueOf(0.35); + //orc config Review comment: > typicall, these properties are all named.. `hoodie.orc.string.schema` etc? you can map these to actual properties inside the Orc classes? I fixed this, thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
