vinothchandar commented on a change in pull request #666: Add support for
dynamic bloom filter to increase efficiency of bloom filter for static sizing
URL: https://github.com/apache/incubator-hudi/pull/666#discussion_r281663186
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/config/HoodieIndexConfig.java
##########
@@ -50,6 +50,9 @@
public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL =
"hoodie.bloom.index.input.storage" + ".level";
public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL =
"MEMORY_AND_DISK_SER";
+ public static final String BLOOM_INDEX_ENABLE_DYNAMIC_PROP =
Review comment:
depends on how you look at it.. At the code level, its weird to suddenly
access an index config in storage.. we can leave it here for now. but let's
rename?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
