n3nash commented on a change in pull request #666: Add support for dynamic
bloom filter to increase efficiency of bloom filter for static sizing
URL: https://github.com/apache/incubator-hudi/pull/666#discussion_r281903110
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/io/storage/HoodieStorageWriterFactory.java
##########
@@ -41,7 +41,7 @@
R extends IndexedRecord> HoodieStorageWriter<R>
newParquetStorageWriter(String commitTime, Path path,
HoodieWriteConfig config, Schema schema, HoodieTable hoodieTable) throws
IOException {
BloomFilter filter = new BloomFilter(config.getBloomFilterNumEntries(),
- config.getBloomFilterFPP());
+ config.getBloomFilterFPP(), false);
Review comment:
I ran tests isolated only on the bloom filter and generated UUID's + random
strings (to simulate non uuid based keys), the test don't go through this code
path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
