pseudomuto commented on a change in pull request #672: [HUDI-113]: Use Tuple2
over # delimited string
URL: https://github.com/apache/incubator-hudi/pull/672#discussion_r283581293
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/index/bloom/HoodieBloomIndex.java
##########
@@ -300,22 +302,22 @@ public boolean isImplicitWithStorage() {
* recordKey ranges in the index info.
*/
@VisibleForTesting
- JavaPairRDD<String, Tuple2<String, HoodieKey>>
explodeRecordRDDWithFileComparisons(
+ JavaPairRDD<Tuple2<String, String>, Tuple2<String, HoodieKey>>
explodeRecordRDDWithFileComparisons(
Review comment:
@vinothchandar Just to be clear, you're suggesting this signature reverts to
`JavaPairRDD<String, Tuple2<String, HoodieKey>>` and we rely on the List
sorting to sort first based on `matchingFile` and then `HoodieKey`, correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
