abhioncbr commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r286287131
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CommitsCommand.java
##########
@@ -131,8 +133,13 @@ public String rollbackCommit(@CliOption(key = {"commit"},
help = "Commit to roll
}
SparkLauncher sparkLauncher = SparkUtil.initLauncher(sparkPropertiesPath);
- sparkLauncher
- .addAppArgs(SparkMain.SparkCommand.ROLLBACK.toString(), commitTime,
HoodieCLI.tableMetadata.getBasePath());
+
+ HoodieCommitRollbackJobConfig config = new HoodieCommitRollbackJobConfig();
Review comment:
@bvaradar thanks for reviewing the changes. I am working on the rest of the
changes. I got the reasoning that a hoodie-common module is a place of core
classes. It would be good if we rename this module as hoodie-core instead of
hoodie-common.
Also, I have a question regarding this comment. Do you want me to put all
the command configs classes into their perspective original
classes/package(where it was before) or in a hoodie-client module?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
