v3nkatesh commented on a change in pull request #685: default implementation for HBase index qps allocator URL: https://github.com/apache/incubator-hudi/pull/685#discussion_r286615733
########## File path: hoodie-client/src/main/java/com/uber/hoodie/index/hbase/HBaseIndexQPSResourceAllocator.java ########## @@ -0,0 +1,30 @@ +/* + * Copyright (c) 2017 Uber Technologies, Inc. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * + */ + +package com.uber.hoodie.index.hbase; + +import java.io.Serializable; + +public interface HBaseIndexQPSResourceAllocator extends Serializable { + + float getQPSFractionForPutsTime(final long numPuts, final int desiredPutsTime); + + float getQPSFraction(final float desiredQPSFraction, final long numPuts); + + void releaseQPSResources(); Review comment: Sorry, did not get your question. If you mean `does releaseQPSResources() also acquire qps fraction` - no, here it is the job of the implementation class to manage the resources acquired and implement a way to release the same when releaseQPSResources() is called. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
