vinothchandar commented on a change in pull request #698: HUDI-135 - Skip Meta
folder when looking for partitions
URL: https://github.com/apache/incubator-hudi/pull/698#discussion_r288352687
##########
File path: hoodie-common/src/main/java/com/uber/hoodie/common/util/FSUtils.java
##########
@@ -201,31 +203,53 @@ public static String getRelativePartitionPath(Path
basePath, Path partitionPath)
partitions.add(getRelativePartitionPath(basePath,
filePath.getParent()));
}
return true;
- });
+ }, true);
return partitions;
}
public static final List<String> getAllDataFilesForMarkers(FileSystem fs,
String basePath, String instantTs,
String markerDir) throws IOException {
List<String> dataFiles = new LinkedList<>();
- FSUtils.processFiles(fs, markerDir, (status) -> {
+ processFiles(fs, markerDir, (status) -> {
Review comment:
Would nt a better strategy be to just list the `.hoodie` folder for marker
files? I feel we are listing the entire table and then throwing it away?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
