n3nash commented on a change in pull request #674: Upgrade to Hive 2.x, MOR
read query fixes and performance improvement
URL: https://github.com/apache/incubator-hudi/pull/674#discussion_r292113080
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormat.java
##########
@@ -206,6 +219,13 @@ static WriterBuilder newWriterBuilder() {
return new HoodieLogFileReader(fs, logFile, readerSchema,
HoodieLogFileReader.DEFAULT_BUFFER_SIZE, false, false);
}
+ static HoodieLogFormat.Reader newReader(FileSystem fs, HoodieLogFile
logFile, Schema readerSchema, boolean
+ readBlockLazily, boolean reverseReader)
+ throws IOException {
+ return new HoodieLogFileReader(fs, logFile, readerSchema,
HoodieLogFileReader.DEFAULT_BUFFER_SIZE,
Review comment:
So, this particular method is so that we can override certain parameters
like reverseReading for custom use-cases which will not be part of the config..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
