bvaradar commented on a change in pull request #727: Ensure log files are
consistently ordered when scanning
URL: https://github.com/apache/incubator-hudi/pull/727#discussion_r292726890
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieMergedLogRecordScanner.java
##########
@@ -110,7 +110,7 @@ protected void processNextRecord(HoodieRecord<? extends
HoodieRecordPayload> hoo
if (records.containsKey(key)) {
// Merge and store the merged record. The HoodieRecordPayload
implementation is free to decide what should be
// done when a delete (empty payload) is encountered before or after an
insert/update.
- HoodieRecordPayload combinedValue =
records.get(key).getData().preCombine(hoodieRecord.getData());
+ HoodieRecordPayload combinedValue =
hoodieRecord.getData().preCombine(records.get(key).getData());
Review comment:
I have changed the order of precombine here. HoodieAvroPayload has a
consistent behavior across precombine and combineAndGet APIs where it favors
this instance over another. Inorder to keep the same semantics, the ordering
needs to be changed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
