This is an automated email from the ASF dual-hosted git repository.

vinoth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new 136f847  TestMergeOnReadTable must use embedded timeline server
136f847 is described below

commit 136f8478a3d8deb1e2c00ee2bf45dd5f25fcb87f
Author: Balaji Varadarajan <[email protected]>
AuthorDate: Wed Jun 12 18:28:49 2019 -0700

    TestMergeOnReadTable must use embedded timeline server
---
 .../uber/hoodie/table/TestMergeOnReadTable.java    |  2 +
 .../TestMergeonReadTableWithEmbeddedServer.java    | 56 ----------------------
 2 files changed, 2 insertions(+), 56 deletions(-)

diff --git 
a/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeOnReadTable.java 
b/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeOnReadTable.java
index 73796e4..1c95e9f 100644
--- 
a/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeOnReadTable.java
+++ 
b/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeOnReadTable.java
@@ -733,6 +733,7 @@ public class TestMergeOnReadTable {
         
.withAutoCommit(false).withAssumeDatePartitioning(true).withCompactionConfig(HoodieCompactionConfig.newBuilder()
             .compactionSmallFileSize(1 * 1024).withInlineCompaction(false)
             .withMaxNumDeltaCommitsBeforeCompaction(1).build())
+        .withEmbeddedTimelineServerEnabled(true)
         .withStorageConfig(HoodieStorageConfig.newBuilder().limitFileSize(1 * 
1024).build())
         .forTable("test-trip-table").build();
   }
@@ -1310,6 +1311,7 @@ public class TestMergeOnReadTable {
             HoodieCompactionConfig.newBuilder().compactionSmallFileSize(1024 * 
1024 * 1024).withInlineCompaction(false)
                 .withMaxNumDeltaCommitsBeforeCompaction(1).build())
         .withStorageConfig(HoodieStorageConfig.newBuilder().limitFileSize(1024 
* 1024 * 1024).build())
+        .withEmbeddedTimelineServerEnabled(true)
         .forTable("test-trip-table")
         
.withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(indexType).build());
   }
diff --git 
a/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeonReadTableWithEmbeddedServer.java
 
b/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeonReadTableWithEmbeddedServer.java
deleted file mode 100644
index 75fdab4..0000000
--- 
a/hoodie-client/src/test/java/com/uber/hoodie/table/TestMergeonReadTableWithEmbeddedServer.java
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.uber.hoodie.table;
-
-import static 
com.uber.hoodie.common.HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA;
-
-import com.uber.hoodie.config.HoodieCompactionConfig;
-import com.uber.hoodie.config.HoodieIndexConfig;
-import com.uber.hoodie.config.HoodieStorageConfig;
-import com.uber.hoodie.config.HoodieWriteConfig;
-import com.uber.hoodie.index.HoodieIndex;
-
-public class TestMergeonReadTableWithEmbeddedServer extends 
TestMergeOnReadTable {
-
-  @Override
-  protected HoodieWriteConfig.Builder getConfigBuilder(Boolean autoCommit, 
HoodieIndex.IndexType indexType) {
-    return 
HoodieWriteConfig.newBuilder().withPath(basePath).withSchema(TRIP_EXAMPLE_SCHEMA).withParallelism(2,
 2)
-        .withAutoCommit(autoCommit).withAssumeDatePartitioning(true)
-        .withCompactionConfig(
-            HoodieCompactionConfig.newBuilder().compactionSmallFileSize(1024 * 
1024 * 1024).withInlineCompaction(false)
-                .withMaxNumDeltaCommitsBeforeCompaction(1).build())
-        .withStorageConfig(HoodieStorageConfig.newBuilder().limitFileSize(1024 
* 1024 * 1024).build())
-        .withEmbeddedTimelineServerEnabled(true)
-        .forTable("test-trip-table")
-        
.withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(indexType).build());
-  }
-
-  @Override
-  protected HoodieWriteConfig getHoodieWriteConfigWithSmallFileHandlingOff() {
-    return HoodieWriteConfig.newBuilder().withPath(basePath)
-        .withSchema(TRIP_EXAMPLE_SCHEMA)
-        .withParallelism(2, 2)
-        
.withAutoCommit(false).withAssumeDatePartitioning(true).withCompactionConfig(HoodieCompactionConfig.newBuilder()
-            .compactionSmallFileSize(1 * 1024).withInlineCompaction(false)
-            .withMaxNumDeltaCommitsBeforeCompaction(1).build())
-        .withEmbeddedTimelineServerEnabled(true)
-        .withStorageConfig(HoodieStorageConfig.newBuilder().limitFileSize(1 * 
1024).build())
-        .forTable("test-trip-table").build();
-  }
-}

Reply via email to