vinothchandar commented on a change in pull request #746: Cleaning up pom and 
other dependencies
URL: https://github.com/apache/incubator-hudi/pull/746#discussion_r295099979
 
 

 ##########
 File path: hoodie-hive/pom.xml
 ##########
 @@ -71,16 +71,19 @@
     <dependency>
       <groupId>commons-dbcp</groupId>
       <artifactId>commons-dbcp</artifactId>
+      <scope>provided</scope>
 
 Review comment:
   these provided should be enforced at bundle level. so remove? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to