bvaradar commented on a change in pull request #700: HUDI-138 - Meta Files
handling also need to support consistency guard
URL: https://github.com/apache/incubator-hudi/pull/700#discussion_r296458594
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTableMetaClient.java
##########
@@ -190,13 +201,27 @@ public HoodieTableConfig getTableConfig() {
/**
* Get the FS implementation for this table
*/
- public FileSystem getFs() {
+ public HoodieWrapperFileSystem getFs() {
if (fs == null) {
- fs = FSUtils.getFs(metaPath, hadoopConf.get());
+ FileSystem fileSystem = FSUtils.getFs(metaPath, hadoopConf.get());
+ if (fileSystem instanceof HoodieWrapperFileSystem) {
Review comment:
This was a defensive check as the effect of nesting could result in longer
wait times. With the current code, this should not happen. I can replace with
a precondition that we should never see a HoodieWrapperFileSystem. Let me know
how it sounds ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
