vinothchandar commented on a change in pull request #700: HUDI-138 - Meta Files 
handling also need to support consistency guard
URL: https://github.com/apache/incubator-hudi/pull/700#discussion_r297002776
 
 

 ##########
 File path: 
hoodie-common/src/main/java/com/uber/hoodie/common/io/storage/HoodieWrapperFileSystem.java
 ##########
 @@ -377,7 +399,15 @@ public FSDataOutputStream createNonRecursive(Path f, 
FsPermission permission,
 
   @Override
   public boolean createNewFile(Path f) throws IOException {
-    return fileSystem.createNewFile(convertToDefaultPath(f));
+    boolean newFile = fileSystem.createNewFile(convertToDefaultPath(f));
 
 Review comment:
   should we cover `mkdirs` as well? also createNonRecursive and other write 
methods? Can you skim this file for any write operation that we may have to 
consider?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to