n3nash commented on a change in pull request #788: HUDI-168 Ensure 
getFileStatus calls for files getting written happens after close() is called
URL: https://github.com/apache/incubator-hudi/pull/788#discussion_r303562388
 
 

 ##########
 File path: 
hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java
 ##########
 @@ -527,6 +525,10 @@ private HoodieRollbackStat rollback(HoodieIndex 
hoodieIndex, String partitionPat
               if (writer != null) {
                 writer.close();
               }
+              if (success) {
 
 Review comment:
   Can you leave comments here detailing the reason we are doing this is due to 
different file system guarantees of HDfs and cloud ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to