vinothchandar commented on a change in pull request #788: HUDI-168 Ensure
getFileStatus calls for files getting written happens after close() is called
URL: https://github.com/apache/incubator-hudi/pull/788#discussion_r303619221
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java
##########
@@ -527,6 +525,10 @@ private HoodieRollbackStat rollback(HoodieIndex
hoodieIndex, String partitionPat
if (writer != null) {
writer.close();
}
+ if (success) {
Review comment:
+1 to @n3nash 's point. but I think its generally safe to do this. even with
hdfs, length is not updates until the hflush/hsync etc is called..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
