vinothchandar commented on a change in pull request #830: HUDI-123 Rename code packages/constants to org.apache.hudi URL: https://github.com/apache/incubator-hudi/pull/830#discussion_r312762335
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/adhoc/UpgradePayloadFromUberToApache.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.adhoc; + +import com.beust.jcommander.JCommander; +import com.beust.jcommander.Parameter; +import java.io.BufferedReader; +import java.io.FileReader; +import java.io.IOException; +import java.io.Serializable; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.HoodieTableConfig; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.FSUtils; +import org.apache.hudi.config.HoodieCompactionConfig; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +/** + * This is an one-time use class meant for migrating the configuration for + * "hoodie.compaction.payload.class" in .hoodie/hoodie.properties from com.uber.hoodie to + * org.apache.hudi + * It takes in a file containing base-paths for a set of hudi datasets and does the migration + */ +public class UpgradePayloadFromUberToApache implements Serializable { + + private static Logger logger = LogManager.getLogger(UpgradePayloadFromUberToApache.class); + + private final Config cfg; + + public UpgradePayloadFromUberToApache(Config cfg) { + this.cfg = cfg; + } + + public void run() throws IOException { + BufferedReader reader = new BufferedReader(new FileReader(cfg.inputPath)); + String basePath = reader.readLine(); + while (basePath != null) { + basePath = basePath.trim(); + if (!basePath.startsWith("#")) { + logger.info("Performing upgrade for " + basePath); + String metaPath = String.format("%s/.hoodie", basePath); + HoodieTableMetaClient metaClient = new HoodieTableMetaClient( + FSUtils.prepareHadoopConf(new Configuration()), basePath, false); + HoodieTableConfig tableConfig = metaClient.getTableConfig(); + if (tableConfig.getTableType().equals(HoodieTableType.MERGE_ON_READ)) { + Map<String, String> propsMap = tableConfig.getProps(); + if (propsMap.containsKey(HoodieCompactionConfig.PAYLOAD_CLASS_PROP)) { + String payloadClass = propsMap.get(HoodieCompactionConfig.PAYLOAD_CLASS_PROP); + logger.info("Found payload class=" + payloadClass); + if (payloadClass.startsWith("com.uber.hoodie")) { + String newPayloadClass = payloadClass.replace("com.uber.hoodie", + "org.apache.hudi"); + logger.info("Replacing payload class (" + payloadClass + + ") with (" + newPayloadClass + ")"); + Map<String, String> newPropsMap = new HashMap<>(propsMap); + newPropsMap.put(HoodieCompactionConfig.PAYLOAD_CLASS_PROP, newPayloadClass); + Properties props = new Properties(); + props.putAll(newPropsMap); + tableConfig.createHoodieProperties(metaClient.getFs(), new Path(metaPath), props); Review comment: this overwrites the existing file? so writers or readers could see partial data? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
