yanghua commented on a change in pull request #834: [HUDI-205] Let checkstyle
ban Java and Guava Optional instead of using Option provided by Hudi
URL: https://github.com/apache/incubator-hudi/pull/834#discussion_r313660014
##########
File path: style/checkstyle.xml
##########
@@ -242,5 +242,8 @@
<property name="exceptionVariableName" value="expected"/>
</module>
<module name="CommentsIndentation"/>
+ <module name="IllegalImport">
Review comment:
Yes, right. We already provided `Option` and some utility converter methods,
the code style should be consistency. Users can use those methods in the
scenarios where return `java.util.Optional` or Guava Optional, e.g. calling
java streaming API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
