bvaradar commented on a change in pull request #853: Ignore duplicate of a 
compaction file
URL: https://github.com/apache/incubator-hudi/pull/853#discussion_r318313395
 
 

 ##########
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/util/CompactionUtils.java
 ##########
 @@ -150,11 +150,18 @@ public static HoodieCompactionPlan 
getCompactionPlan(HoodieTableMetaClient metaC
     pendingCompactionPlanWithInstants.stream().flatMap(instantPlanPair -> {
       return getPendingCompactionOperations(instantPlanPair.getKey(), 
instantPlanPair.getValue());
     }).forEach(pair -> {
-      // Defensive check to ensure a single-fileId does not have more than one 
pending compaction
+      // Defensive check to ensure a single-fileId does not have more than one 
pending compaction with different
+      // params. If we find a full dub we assume it is caused by eventual 
nature of the move operation on some DFSs.
 
 Review comment:
   Nit: dub -> duplicate 
   
   pending compaction with different params => pending compaction with 
different file-slices
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to