leesf commented on issue #861: [HUDI-225] Create Hudi Timeline Server Fat Jar URL: https://github.com/apache/incubator-hudi/pull/861#issuecomment-526392030 @vinothchandar @bvaradar Thanks for the review, addressed the comments and squashed the commits. And two things to point out. First when running mvn notice:generate from top-level module, the notice file(NOTICE.txt and HUDI_NOTICE.txt) in other modules(such as hudi-hadoop-mr and packaging/hudi-hadoop-mr-bundle) have been modified, so should we open anthor PR to update NOTICE file? And i am willing to do this work. Second. In windows environment, running mvn notice:generate gets the following exception: > Failed to execute goal org.jasig.maven:maven-notice-plugin:1.1.0:generate (default-cli) on project hudi: Resource not found in file system, classpath or URL: file://F:/community /incubator-hudi/release/config/license-mappings.xml And it can be fix by removing _file://_ in configuration, and it works well in windows and linux. So should i file another jira ticket to track it?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
