vinothchandar commented on a change in pull request #866: HUDI-170 Updating
hoodie record before inserting it into ExternalSpillableMap
URL: https://github.com/apache/incubator-hudi/pull/866#discussion_r319578665
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -207,9 +207,10 @@ private String init(String fileId,
Iterator<HoodieRecord<T>> newRecordsItr) {
while (newRecordsItr.hasNext()) {
HoodieRecord<T> record = newRecordsItr.next();
partitionPath = record.getPartitionPath();
- keyToNewRecords.put(record.getRecordKey(), record);
// update the new location of the record, so we know where to find it
next
record.setNewLocation(new HoodieRecordLocation(instantTime, fileId));
+ //NOTE: Once Records are added to map (spillable-map), DO NOT change it
as they won't persist
+ keyToNewRecords.put(record.getRecordKey(), record);
Review comment:
lgtm. we should ideally seal the record. filed HUDI-232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
