vinothchandar commented on a change in pull request #875: [HUDI-236] Failed to 
close stream
URL: https://github.com/apache/incubator-hudi/pull/875#discussion_r320539019
 
 

 ##########
 File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieWithTimelineServer.java
 ##########
 @@ -124,6 +127,22 @@ public String sendRequest(String driverHost, int port) 
throws RuntimeException {
       return result.toString();
     } catch (Exception ex) {
       throw new RuntimeException(ex);
+    } finally {
 
 Review comment:
   could we use try with resources 
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
 
   and make it shorter? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to