vinothchandar commented on a change in pull request #873: [HUDI-159]
Redesigning bundles for lighter-weight integrations
URL: https://github.com/apache/incubator-hudi/pull/873#discussion_r320949212
##########
File path: packaging/hudi-hive-bundle/pom.xml
##########
@@ -169,53 +50,22 @@
</goals>
<configuration>
<createSourcesJar>true</createSourcesJar>
- <relocations>
- <relocation>
- <pattern>com.beust.</pattern>
- <shadedPattern>org.apache.hudi.com.beust.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>org.joda.</pattern>
- <shadedPattern>org.apache.hudi.org.joda.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>com.google.</pattern>
- <shadedPattern>org.apache.hudi.com.google.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>org.slf4j.</pattern>
- <shadedPattern>org.apache.hudi.org.slf4j.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>org.apache.commons.</pattern>
-
<shadedPattern>org.apache.hudi.org.apache.commons.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>parquet.column</pattern>
-
<shadedPattern>org.apache.hudi.parquet.column</shadedPattern>
- </relocation>
- <relocation>
- <pattern>parquet.format.</pattern>
-
<shadedPattern>org.apache.hudi.parquet.format.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>parquet.hadoop.</pattern>
-
<shadedPattern>org.apache.hudi.parquet.hadoop.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>parquet.schema.</pattern>
-
<shadedPattern>org.apache.hudi.parquet.schema.</shadedPattern>
- </relocation>
- </relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+
<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml
+ </dependencyReducedPomLocation>
<artifactSet>
- <excludes>
- <exclude>log4j:log4j</exclude>
- <exclude>org.apache.hadoop:*</exclude>
- <exclude>org.apache.hive:*</exclude>
- <exclude>org.apache.derby:derby</exclude>
- </excludes>
+ <includes>
+ <include>org.apache.hudi:hudi-common</include>
+ <include>org.apache.hudi:hudi-hadoop-mr</include>
+ <include>org.apache.hudi:hudi-hive</include>
+
+ <include>com.beust:jcommander</include>
+ <include>org.apache.parquet:parquet-avro</include>
Review comment:
@umehrot2 http://hudi.apache.org/querying_data.html#hive you actually use
the mr bundle for Hive integration (I know its confusing for now. but
hive-bundle needs to be renamed hive-sync-bundle. its only used for registering
tables to Hive) .
Will address other feedback once more folks look at it as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
