umehrot2 commented on a change in pull request #770: remove
com.databricks:spark-avro to build spark avro schema by itself
URL: https://github.com/apache/incubator-hudi/pull/770#discussion_r324935297
##########
File path:
hoodie-spark/src/main/scala/com/uber/hoodie/AvroConversionUtils.scala
##########
@@ -272,12 +112,23 @@ object AvroConversionUtils {
case ShortType => (item: Any) =>
if (item == null) null else item.asInstanceOf[Short].intValue
case _: DecimalType => (item: Any) => if (item == null) null else
item.toString
Review comment:
This line needs to be removed, otherwise `Decimal` is still being converted
to `String`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services