yanghua commented on issue #896: Updating site to reflect recent doc changes
URL: https://github.com/apache/incubator-hudi/pull/896#issuecomment-533190448
 
 
   @bhasudha Maybe the current state is right. We should not remove the first 
'/'. Please consider a similar example in Flink 
project:https://github.com/apache/flink/blob/master/docs/_layouts/base.html#L33 
(please ignore `{{ site.baseurl }}` for the locally generated HTML files). And 
these codes would be parsed in like this (in a special full HTML page file):
   
   ```
       <link rel="stylesheet" href="/page/css/flink.css">
       <link rel="stylesheet" href="/page/css/syntax.css">
       <link rel="stylesheet" href="/page/css/codetabs.css">
       <link rel="stylesheet" 
href="/page/font-awesome/css/font-awesome.min.css">
   ```
   
   If I open the local HTML file in the browser, it can not be rendered 
correctly, it looks like [this 
image](https://issues.apache.org/jira/secure/attachment/12980752/Screen%20Shot%202019-09-19%20at%2011.14.09%20PM.png)
   
   So, IMO, we do not need the HTML file to be rendered correctly by opening it 
in the browser. We just need to check it works OK when we start the site with 
Jekyll. Additionally, for debugging purposes, Jekyll supports 
hot-deploy(regenerate and reload changed files automatically and does not need 
to restart), it does not affect efficiency.
   
   Generally speaking, IMHO, we can ignore this issue. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to