[
https://issues.apache.org/jira/browse/HUDI-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934894#comment-16934894
]
vinoyang commented on HUDI-267:
-------------------------------
+1 to rename {{HoodieTableMetaClient.initializePathAsHoodieDataset}} to
{{HoodieTableMetaClient.initDatasetAndGetMetaClient}}
Yes, there are some code need further refactor, let us do it step by step.
> Refactor bad method name HoodieTestUtils#initTableType
> ------------------------------------------------------
>
> Key: HUDI-267
> URL: https://issues.apache.org/jira/browse/HUDI-267
> Project: Apache Hudi (incubating)
> Issue Type: Sub-task
> Components: Testing
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
>
> There are some bad method name about {{HoodieTableMetaClient}}, e.g.
> （1） {{HoodieTestUtils#initTableType}}: it returns an instance of
> {{HoodieTableMetaClient}}, not about initializing table type, while it has a
> side effort: it initializes the path as hoodie dataset.
> （2）{{HoodieTableMetaClient.initializePathAsHoodieDataset}} it also returns an
> instance of {{HoodieTableMetaClient}}, however, from its name, it seems we
> want to initialize path?
> I would like to suggest rename:
> (1) {{HoodieTestUtils#initTableType}} to {{HoodieTestUtils#init}} as a
> override method like others;
> (2) {{HoodieTableMetaClient.initializePathAsHoodieDataset}} to
> {{HoodieTableMetaClient.initializeMetaClientWithPathAsHoodieDataset}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
