yanghua commented on a change in pull request #916: HUDI-267 Refactor bad 
method name HoodieTestUtils#initTableType and 
HoodieTableMetaClient#initializePathAsHoodieDataset
URL: https://github.com/apache/incubator-hudi/pull/916#discussion_r326860182
 
 

 ##########
 File path: 
hudi-common/src/test/java/org/apache/hudi/common/model/HoodieTestUtils.java
 ##########
 @@ -96,21 +96,20 @@ public static HoodieTableMetaClient init(String basePath)
   }
 
   public static HoodieTableMetaClient init(String basePath, HoodieTableType 
tableType) throws IOException {
-    return initTableType(getDefaultHadoopConf(), basePath, tableType);
+    return init(getDefaultHadoopConf(), basePath, tableType);
   }
 
   public static HoodieTableMetaClient init(Configuration hadoopConf, String 
basePath)
       throws IOException {
-    return initTableType(hadoopConf, basePath, HoodieTableType.COPY_ON_WRITE);
+    return init(hadoopConf, basePath, HoodieTableType.COPY_ON_WRITE);
   }
 
-  public static HoodieTableMetaClient initTableType(Configuration hadoopConf, 
String basePath,
-      HoodieTableType tableType) throws IOException {
+  public static HoodieTableMetaClient init(Configuration hadoopConf, String 
basePath, HoodieTableType tableType) throws IOException {
 
 Review comment:
   @leesf Thanks for reminding me. I have fixed the checkstyle issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to