vinothchandar commented on a change in pull request #918: HUDI-121 : Address
comments during RC2 voting
URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327378727
##########
File path: packaging/hudi-timeline-server-bundle/pom.xml
##########
@@ -170,12 +170,96 @@
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
- <!-- Use this jar's NOTICE and license file -->
- <exclude>META-INF/NOTICE*</exclude>
- <exclude>META-INF/LICENSE*</exclude>
+ <exclude>META-INF/services/javax.*</exclude>
</excludes>
</filter>
</filters>
+ <artifactSet>
+ <includes>
+ <include>org.apache.hudi:hudi-common</include>
+ <include>org.apache.httpcomponents:httpclient</include>
+ <include>org.apache.httpcomponents:httpcore</include>
+ <include>org.mortbay.jetty:jetty</include>
+ <include>org.mortbay.jetty:jetty-util</include>
+ <include>com.esotericsoftware:kryo-shaded</include>
+ <include>com.esotericsoftware:minlog</include>
+ <include>org.objenesis:objenesis</include>
+ <include>org.apache.hudi:hudi-timeline-service</include>
+ <include>log4j:log4j</include>
+
<include>com.fasterxml.jackson.core:jackson-annotations</include>
+
<include>com.fasterxml.jackson.core:jackson-core</include>
+
<include>com.fasterxml.jackson.core:jackson-databind</include>
+ <include>org.apache.httpcomponents:fluent-hc</include>
+ <include>commons-logging:commons-logging</include>
+ <include>io.javalin:javalin</include>
+
<include>org.jetbrains.kotlin:kotlin-stdlib-jdk8</include>
+ <include>org.jetbrains.kotlin:kotlin-stdlib</include>
+
<include>org.jetbrains.kotlin:kotlin-stdlib-common</include>
+ <include>org.jetbrains:annotations</include>
+
<include>org.jetbrains.kotlin:kotlin-stdlib-jdk7</include>
+ <include>org.slf4j:slf4j-api</include>
+ <include>org.eclipse.jetty:jetty-server</include>
+ <include>javax.servlet:javax.servlet-api</include>
Review comment:
I am wondering if this list can be simplified further..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
