lresende commented on a change in pull request #918: [HUDI-121] : Address comments during RC2 voting URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327910958
########## File path: pom.xml ########## @@ -394,18 +369,18 @@ </licenseFamily> </licenseFamilies> <excludes> + <exclude>NOTICE</exclude> <exclude>**/.*</exclude> - <exclude>**/*.txt</exclude> - <exclude>**/*.sh</exclude> - <exclude>**/*.log</exclude> + <exclude>**/*.json</exclude> + <exclude>**/*.sqltemplate</exclude> + <exclude>**/compose_env</exclude> + <exclude>**/*NOTICE*</exclude> + <exclude>**/*LICENSE*</exclude> Review comment: why the pom below is excluded? pom file can have a license header. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services