bvaradar commented on a change in pull request #918: [HUDI-121] : Address
comments during RC2 voting
URL: https://github.com/apache/incubator-hudi/pull/918#discussion_r327919087
##########
File path: pom.xml
##########
@@ -394,18 +369,18 @@
</licenseFamily>
</licenseFamilies>
<excludes>
+ <exclude>NOTICE</exclude>
<exclude>**/.*</exclude>
- <exclude>**/*.txt</exclude>
- <exclude>**/*.sh</exclude>
- <exclude>**/*.log</exclude>
+ <exclude>**/*.json</exclude>
+ <exclude>**/*.sqltemplate</exclude>
+ <exclude>**/compose_env</exclude>
+ <exclude>**/*NOTICE*</exclude>
+ <exclude>**/*LICENSE*</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
- <exclude>**/test/resources/*.avsc</exclude>
<exclude>**/test/resources/*.data</exclude>
- <exclude>**/test/resources/*.schema</exclude>
- <exclude>**/test/resources/*.csv</exclude>
- <exclude>**/main/avro/*.avsc</exclude>
- <exclude>**/target/*</exclude>
+ <exclude>**/target/**</exclude>
<exclude>**/style/*</exclude>
+ <excludes>**/generated-sources/**</excludes>
Review comment:
@lresende : this is for checkstyle and code-formatting rules. We can remove
this as the underlying xml files are not auto-generated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
