vinothchandar commented on a change in pull request #923: HUDI-247 Unify the
initialization of HoodieTableMetaClient in test for hoodie-client module
URL: https://github.com/apache/incubator-hudi/pull/923#discussion_r328408448
##########
File path:
hudi-client/src/test/java/org/apache/hudi/index/bloom/TestHoodieBloomIndex.java
##########
@@ -353,8 +352,8 @@ public void testTagLocation() throws Exception {
HoodieClientTestUtils.writeParquetFile(basePath, "2015/01/31",
Arrays.asList(record4), schema, null, true);
// We do the tag again
- metadata = new HoodieTableMetaClient(jsc.hadoopConfiguration(), basePath);
Review comment:
I kind of prefer to have it be a new instance? instead of introducing a
reload method.. Those things tend to get tricky over time (someone forget to
reset one variable etc).. wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
