leesf commented on a change in pull request #928: [HUDI-265] Failed to delete
tmp dirs created in unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#discussion_r329287508
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/table/log/HoodieLogFormatTest.java
##########
@@ -78,6 +80,8 @@
@RunWith(Parameterized.class)
public class HoodieLogFormatTest {
+ @Rule
+ public TemporaryFolder folder = new TemporaryFolder();
Review comment:
Since hoodie-client module relies on hoodie-common module, I think we can
make HoodieClientTestHarness extend HoodieCommonTestHarness, and move some
methods from HoodieClientTestHarness to HoodieCommonTestHarness. Then make some
common test units extend from HoodieCommonTestHarness. CC @vinothchandar
@yanghua
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
