bvaradar commented on issue #915: [HUDI-268] Shade and relocate Avro dependency in hadoop-mr-bundle URL: https://github.com/apache/incubator-hudi/pull/915#issuecomment-537163855 > > @vinothchandar @bvaradar updated the PR > > > Just few nits.. But the integration test seems to fail? ideas? > > @vinothchandar I noticed an issue with this approach today, and probably thats why the integration tests are failing. > > When we will build with the profile `shade-avro` things would be file, but when we build without this profile it can cause other things to break. Because we have always added an `<include>` for the avro dependency as well as `<relocation>` for avro and are just trying to turn shading on or off using `scope`. However, when the scope is `provided`, due to our inclusion of `relocation` section all references to `org.apache.avro` in our code/jar would be replaced with `org.apache.hudi.org.apache.avro`. However, it will not actually find that relocated dependency because it has not actually been shaded/relocated because of the scope. This will cause runtime errors. > > Essentially, now I am not able to find a good way how to activate/deactivate the shading. Only way now I can think of is adding the whole `shade plugin` with all its contents and the `avro` inside the profile. But that seems like a bad approach to me. > > Have u guys achieved anything like this in the past ? @umehrot2 : This can be fixed by adding another mvn property. I have explained in the comments. Can you please try and see if it works.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
