bvaradar commented on a change in pull request #935: [HUDI-287] Remove LICENSE and NOTICE files in hoodie child modules. URL: https://github.com/apache/incubator-hudi/pull/935#discussion_r330868161
########## File path: pom.xml ########## @@ -166,9 +104,9 @@ </properties> <scm> - <connection>scm:git:[email protected]:apache/incubator-hudi.git</connection> - <developerConnection>scm:git:[email protected]:apache/incubator-hudi.git</developerConnection> - <url>[email protected]:apache/incubator-hudi.git</url> + <connection>scm:git:https://gitbox.apache.org/repos/asf/incubator-hudi.git</connection> Review comment: @tweise : To be compliant for the voting process, I looked into how the parent pom (apache-21.pom) is setup. The corresponding codebase for apache-21.pom is in github but they had similar setup : https://github.com/apache/maven-apache-parent/blob/master/pom.xml . I was not aware of the implication of this change. I am happy to revert the scm configuration as we want developers to use github. Will update the PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
