leesf commented on a change in pull request #945: [HUDI-296] Explore use of
spotless to auto fix formatting errors
URL: https://github.com/apache/incubator-hudi/pull/945#discussion_r333477670
##########
File path: docker/hoodie/hadoop/sparkworker/pom.xml
##########
@@ -30,6 +30,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<checkstyle.skip>true</checkstyle.skip>
+ <main.basedir>${project.parent.parent.basedir}</main.basedir>
Review comment:
I was thinking to open another PR (may also need to define main.basedir as
this PR does) to make mvn clean install works in sub modules(just a minor git
history improvement). However, it would also be done in this PR. So please
merge this PR if there is no other concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
