vinothchandar commented on issue #953: [WIP] [HUDI-121] Fix licensing issues found during RC voting by general incubator group URL: https://github.com/apache/incubator-hudi/pull/953#issuecomment-541715429 Pasting in the -1 for context Sorry but it’s -1 (binding) due to license issues I checked: - incubating in name - signature and hash fine - DISCLAIMER exist (but you might want to consider using the work in progress disclaimer) - LICENSE file is missing the appendix - NOTICE is fine - No unexpected binary file - Source files have ASF headers - Can compile from source This file [1] probably incorrectly has an ASF header on it, you may also want to mention this file in LICENSE. It unclear what the license is of the code contained in this file [2] are you sure you have permission to use this and it’s under a compatible license? The code in here from stack overflow don’t have a compatible license [3], see [4] (and [5]). 1. ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java 2. ./hudi-0.5.0-incubating-rc5/hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java 3. ./hudi-0.5.0-incubating-rc5/hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java 4. https://www.apache.org/legal/resolved.html#stackoverflow 5. https://issues.apache.org/jira/browse/LEGAL-471
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
