vinothchandar commented on a change in pull request #953: [HUDI-121] Fix
licensing issues found during RC voting by general incubator group
URL: https://github.com/apache/incubator-hudi/pull/953#discussion_r335330617
##########
File path: hudi-cli/src/main/scala/org/apache/hudi/cli/SparkHelpers.scala
##########
@@ -56,8 +59,12 @@ object SparkHelpers {
}
def getBloomFilter(file: String, conf: Configuration): String = {
- val footer = ParquetFileReader.readFooter(conf, new Path(file));
- return
footer.getFileMetaData().getKeyValueMetaData().get(HoodieAvroWriteSupport.HOODIE_AVRO_BLOOM_FILTER_METADATA_KEY)
+ val footer = ParquetFileReader.readFooter(conf, new Path(file))
+ val metadataMap: util.Map[String, String] =
footer.getFileMetaData().getKeyValueMetaData()
Review comment:
can we wrap this in a method in `ParquetUtils` class (where we already have
methods for reading the keys etc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
