vinothchandar commented on a change in pull request #942: [HUDI-137] Fix state
transitions for Hudi cleaning action
URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r336828409
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -1002,19 +1004,98 @@ public void clean() throws HoodieIOException {
* Clean up any stale/old files/data lying around (either on file storage or
index storage) based
* on the configurations and CleaningPolicy used. (typically files that no
longer can be used by a
* running query can be cleaned)
+ *
+ * @param startCleanTime Cleaner Instant Timestamp
+ * @return
+ * @throws HoodieIOException in case of any IOException
*/
- private void clean(String startCleanTime) throws HoodieIOException {
+ protected HoodieCleanMetadata clean(String startCleanTime) throws
HoodieIOException {
Review comment:
can we create a `HoodieCleanerClient` and consolidate all the code around
cleaning there? in the interest of keeping HoodieWriteClient better readable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
