vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340178616
########## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hudi.common; + +import org.apache.hadoop.util.hash.Hash; + +/** + * A Factory class to generate different versions of {@link BloomFilter} + */ +public class BloomFilterFactory { + + /** + * Creates a new {@link BloomFilter} with the given args + * @param numEntries total number of entries + * @param errorRate max allowed error rate + * @param bloomFilterVersion bloom filter version + * @return the {@link BloomFilter} thus created + */ + public static BloomFilter createBloomFilter(int numEntries, double errorRate, int bloomFilterVersion) { + return createBloomFilter(numEntries, errorRate, Hash.MURMUR_HASH, bloomFilterVersion); + } + + /** + * Creates a new {@link BloomFilter} with the given args + * @param numEntries total number of entries + * @param errorRate max allowed error rate + * @param hashType type of the hashing function (see + * {@link org.apache.hadoop.util.hash.Hash}). + * @param bloomFilterVersion bloom filter version + * @return the {@link BloomFilter} thus created + */ + public static BloomFilter createBloomFilter(int numEntries, double errorRate, int hashType, int bloomFilterVersion) { + if(bloomFilterVersion == SimpleBloomFilter.VERSION){ Review comment: No. i think we are on the same page. just saying instead of calling it versions, lets just call it type code. `TYPE_CODE` .. What we have is different types of bloom filters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
