bvaradar commented on a change in pull request #996: Fixes to ensure MOR incr
pull provides consistent results
URL: https://github.com/apache/incubator-hudi/pull/996#discussion_r343814975
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -58,19 +59,28 @@
public static final SimpleDateFormat COMMIT_FORMATTER = new
SimpleDateFormat("yyyyMMddHHmmss");
- public static final Set<String> VALID_EXTENSIONS_IN_ACTIVE_TIMELINE = new
HashSet<>(Arrays.asList(new String[] {
+ public static final Set<String> VALID_EXTENSIONS_IN_ACTIVE_TIMELINE = new
HashSet<>(Arrays.asList(new String[]{
COMMIT_EXTENSION, INFLIGHT_COMMIT_EXTENSION, DELTA_COMMIT_EXTENSION,
INFLIGHT_DELTA_COMMIT_EXTENSION,
SAVEPOINT_EXTENSION, INFLIGHT_SAVEPOINT_EXTENSION, CLEAN_EXTENSION,
INFLIGHT_CLEAN_EXTENSION,
INFLIGHT_COMPACTION_EXTENSION, REQUESTED_COMPACTION_EXTENSION,
INFLIGHT_RESTORE_EXTENSION, RESTORE_EXTENSION}));
private static final transient Logger log =
LogManager.getLogger(HoodieActiveTimeline.class);
protected HoodieTableMetaClient metaClient;
+ private static AtomicReference<String> lastInstantTime = new
AtomicReference<>();
/**
* Returns next commit time in the {@link #COMMIT_FORMATTER} format.
+ * Ensures each commit time is atleast 1 second apart since we create COMMIT
times at second granularity
*/
public static String createNewCommitTime() {
- return HoodieActiveTimeline.COMMIT_FORMATTER.format(new Date());
+ lastInstantTime.updateAndGet((oldVal) -> {
+ String newCommitTime;
+ do {
+ newCommitTime = HoodieActiveTimeline.COMMIT_FORMATTER.format(new
Date());
+ } while (oldVal == newCommitTime);
Review comment:
To be defensive, oldVal <= newCommitTime ? And sleep() to avoid busy-wait ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
