umehrot2 commented on a change in pull request #1001: [HUDI-325] Fix Hive
partition error for updated HDFS Hudi table
URL: https://github.com/apache/incubator-hudi/pull/1001#discussion_r343943582
##########
File path: hudi-hive/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -192,7 +192,7 @@ private String getPartitionClause(String partition) {
String alterTable = "ALTER TABLE " + syncConfig.tableName;
for (String partition : partitions) {
String partitionClause = getPartitionClause(partition);
- String fullPartitionPath = FSUtils.getPartitionPath(syncConfig.basePath,
partition).toString();
+ String fullPartitionPath = FSUtils.getURIPath(fs,
FSUtils.getPartitionPath(syncConfig.basePath, partition));
Review comment:
I would add a check here to check `fs.uri` and do this only if it is `hdfs`
and not in case of other file systems. It also makes it explicitly clear why we
are doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
