bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)
URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344032810
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java
##########
@@ -79,7 +79,7 @@ public TimestampBasedKeyGenerator(TypedProperties config) {
@Override
public HoodieKey getKey(GenericRecord record) {
- Object partitionVal = DataSourceUtils.getNestedFieldVal(record,
partitionPathField);
+ Object partitionVal = DataSourceUtils.getNestedFieldVal(record,
partitionPathFields.get(0));
Review comment:
I think we might need to handle the case of composite keys correctly here.
THis may not be contained to this diff alone as I see similar pattern in
base-class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
