vinothchandar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344980603
########## File path: hudi-bench/src/main/java/org/apache/hudi/bench/configuration/DFSDeltaConfig.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.bench.configuration; + +import org.apache.hudi.bench.DeltaInputFormat; +import org.apache.hudi.bench.DeltaOutputType; +import org.apache.hudi.common.SerializableConfiguration; + +/** + * Configuration to hold details about a DFS based sink, implements {@link DeltaConfig} + */ +public class DFSDeltaConfig extends DeltaConfig { + + // The base path where the generated data should be written to. This data will in turn be used to write into a hudi + // dataset + private final String deltaBasePath; + private final String datasetOutputPath; + private final String schemaStr; + // Maximum file size for the files generated + private final Long maxFileSize; + // The current batch id for the sink + private Integer batchId; + + public DFSDeltaConfig(DeltaOutputType deltaOutputType, DeltaInputFormat deltaInputFormat, + SerializableConfiguration configuration, + String deltaBasePath, String targetBasePath, String schemaStr, Long maxFileSize) { + super(deltaOutputType, deltaInputFormat, configuration); + this.deltaBasePath = deltaBasePath; + this.schemaStr = schemaStr; + this.maxFileSize = maxFileSize; + this.datasetOutputPath = targetBasePath; + } + + public String getDeltaBasePath() { + return deltaBasePath; + } + + public String getDatasetOutputPath() { + return datasetOutputPath; + } + + public String getSchemaStr() { + return schemaStr; + } + + public Long getMaxFileSize() { Review comment: I raise the same concerns I did before again.. I feel we are we complicating this with things like file input sizes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
