vinothchandar commented on issue #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#issuecomment-554370625 +1 on this PR. deferring squash finally at merging time would be ideal. +1 on making the build pass first, before we spend more time on it. Ideally we should also add a few "receipes" to the integ test and have them passing too. @yanghua while I agree with you that ideally, we phased this as smaller checkins. But this one is a special case, since it was started even before incubating... So we are where we are.. We can treat Nishith's branch as the current feature branch or even merge this to a feature branch in apache/incubator-hudi (like we did for packaging fixes) and keep iterating there? That would also help @yanghua contribute changes on top of this.. and ultimately merge this into master when ready. My 2c
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
