n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) 
URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r347091099
 
 

 ##########
 File path: docker/demo/config/bench/complex-workflow-dag-mor.yaml
 ##########
 @@ -0,0 +1,104 @@
+first_insert:
 
 Review comment:
   @vinothchandar Did not completely follow your comment about `ramping up by 
writing tests` ?
   
   So, I've added some recipies to the unit tests of the TestSuiteJob which 
will run as part of the build. Some of these other recipies are examples (which 
I have validated) for folks to use. The intent is for these recipies to be used 
for initial understanding of hoodie and for testing of large features. 
   The next step, as you mentioned, is to have a longer running CI job that 
runs this recipe (which happens now as part of a docker step that I've added to 
the documentation PR : https://github.com/apache/incubator-hudi/pull/626).
   So I have 2 proposals : 
   1) We can either run this recipe as part of the integration test setup that 
runs all the docker steps
   2) We can have a CI job that runs this recipe

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to