lamber-ken commented on a change in pull request #1022: [HUDI-342] add pull request template for hudi project URL: https://github.com/apache/incubator-hudi/pull/1022#discussion_r347733901
########## File path: .github/PULL_REQUEST_TEMPLATE.md ########## @@ -0,0 +1,34 @@ +## *Tips* +- *Thank you very much for contributing to Apache Hudi.* +- *Please review https://hudi.apache.org/contributing.html before opening a pull request.* + +## What is the purpose of the pull request + +*(For example: This pull request adds quick-start document.)* + +## Brief change log + +*(for example:)* + - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* + +## Verify this pull request + +*(Please pick either of the following options)* + +This pull request is a trivial rework / code cleanup without any test coverage. + +*(or)* + +This pull request is already covered by existing tests, such as *(please describe tests)*. Review comment: > How about adding below content? > > (or) > > This change added tests and can be verified as follows: > > _(example:)_ > > * _Added integration tests for end-to-end_ > * _Added HoodieClientWriteTest to verify the change_ > * _Manually verified the change by running a job locally_ 👍 , done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
