nsivabalan commented on a change in pull request #1004: [HUDI-328] Adding
delete api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r348646876
##########
File path:
hudi-client/src/test/java/org/apache/hudi/TestHoodieClientOnCopyOnWriteStorage.java
##########
@@ -274,6 +275,15 @@ private void testUpsertsInternal(HoodieWriteConfig
hoodieWriteConfig,
updateBatch(hoodieWriteConfig, client, newCommitTime, prevCommitTime,
Option.of(Arrays.asList(commitTimeBetweenPrevAndNew)), initCommitTime,
numRecords, writeFn, isPrepped, true,
numRecords, 200, 2);
+
+ // Delete 1
+ prevCommitTime = newCommitTime;
+ newCommitTime = "005";
+ numRecords = 50;
+
+ deleteBatch(hoodieWriteConfig, client, newCommitTime, prevCommitTime,
Review comment:
I wrote a
test(TestHoodieClientOnCopyOnWriteStorage#testDeletesWithoutInserts), but the
config had record schema. Fixed it to have null schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
