hddong commented on a change in pull request #1024: [HUDI-345] Fix used 
deprecated function
URL: https://github.com/apache/incubator-hudi/pull/1024#discussion_r348926966
 
 

 ##########
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/io/storage/SizeAwareFSDataOutputStream.java
 ##########
 @@ -43,7 +43,7 @@
 
   public SizeAwareFSDataOutputStream(Path path, FSDataOutputStream out, 
ConsistencyGuard consistencyGuard,
       Runnable closeCallback) throws IOException {
-    super(out);
+    super(out, null);
 
 Review comment:
   > is it okay to pass null here? this is the stats object right?
   
   Actually, `super(out)` is equivalent to `super(out, null)`. Source code 
below:
   ```
     @Deprecated
     public FSDataOutputStream(OutputStream out) throws IOException {
       this(out, null);
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to